Fix the problem with long strings by Landay7 · Pull Request #18 · mdsteele/rust-msi
github.com
Hi! Thank you for your work, I tried to play with it and figured out that there is an issue with the long string. Basically, it doesn't read fully long string and after that, all strings are messed...

Not to throw shade, just wishing that somebody here can understand. Whenever an input is reasonably long, an analyzing function will crash, and this PR aims to fix that with a mechanism that contradicts the maintainer’s understanding while a similar C implementation does not need this fix. Clearly, the maintainer has not heard a certain programming mantra…

  • Solemarc@lemmy.world
    2·
    7 months ago

    What mantra? I think this maintainer is doing the right thing here by trying to understand why this fix works.

    You should always attempt to address the root cause of an issue instead of slapping band aid patches onto everything.

    To me it looks like the maintainer is trying to find out what exactly is wrong. “this doesn’t happen in our C implementation” implies that there’s something wrong with the rust code specifically.