• 0 Posts
  • 12 Comments
Joined 2 years ago
cake
Cake day: July 24th, 2023

help-circle
  • But you’re also missing one use of the impl keyword: fn func() -> impl Trait.

    […] So dropping the impl in [return position] might not be completely impossible like the other uses of impl.

    But the impl markes that it is a trait to the programmers.
    Take the following functions:

    func1()->A{...}
    func2()->A{...}
    

    Does the following snippet compile?

    let mut thing = func1();
    thing = func2();
    

    Under the current rules we know it will. But if A could be a trait, the functions could return different types. We currently mark that with the impl.


    Why? What value does -> () provide? Why not elide that?

    What value is provided by keeping it?

    What value does cluttering up your code with -> () provide?

    Why a syntactic special-case for exactly that type and not any other random type?

    Because the unit type is special, just like the never ! type. () also has the special importance of being the return value of an empty statement and some other stuff.


    languages w/o [semicolons] feel awkward since you’re generally limited to one statement per line

    Then fixing that might make sense. :-)

    It’s fixed with semicolons ;-)









  • I was a bit apprehensive because rust has like a gazillion different function types but here it seems to work like just any other language with a HM type system.

    The fn(T)->R syntax works for functions without associated data, it discards details of the implementation and works like function pointers in C. This allows them to be copy and 'static.

    The other function types can have data with them and have more type information at compile time which allows them to be inlined.
    These functions each have their own unwritable type that implements the function traits (Fn(T)->R, FnMut(T)->R and FnOnce(T)->R) depending on their enclosed data.

    I hope I remembered everything right from this video by Jon Gjengset.



  • The new version seems to fix that since your comment was written, but it will stil panics if less than 2 samples are provided, unless the crate it wraps panics at an earlier point.

    let peak = buf
                .iter()
                .copied()
                .enumerate()
                .take(self.sample_count / 2)
                .max_by_key(|(_, s)| (s.abs() * 1000.0) as u32)
                .expect("to have at least 1 sample");